This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
[WIP] React FE #53
Merged
[WIP] React FE #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Looks already pretty good to me! I'm totally fine with adding more tests in a later PR. Having the front-end setup should make it easier for us to shizzle away at some interesting details. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Agreed, "the installer works" seems like a decent first test. Maybe just leave a |
|
Okay, I'll merge this puppy now just to make sure that we can all have something to work with ✌️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the poll in #47 it looks like React is the popular option.
This is a loose WIP for reactifying the existing front end. There are few things I still want to be their own components (like the super fancy cube spinner).
Also, this currently has 0 react tests so I'll want to bring in something like
enzymebefore this gets merged.